Integrity error in get_or_create

[Anuranjit maindola]

I came across an issue. Consider a code example below

class Config(models.Model):
    key = models.CharField(max_length=100)
    value = models.CharField(max_length=100)
    def save(self, *args, **kwargs):
         super(Config, self).save(*args, **kwargs)
         super(Config, self).save(*args, **kwargs)

Now if for the Above model I do

params = {"key":"1", "value": "2"}
obj, created = Config.objects.get_or_create(**params)

I get an Integrity Error for Primary Key i.e. the database id field.

The issue as i understood comes because Django tries to insert again with duplicate Primary key. In get_or_create the create method is called with force_insert=True and a particular check in _save_table fails (line number 897) . (If this check passes django is supposed to do an update).

    # If possible, try an UPDATE. If that doesn't update anything, do an INSERT.
    if pk_set and not force_insert:

[Tim Graham]

What's the reason for calling super().save() twice?

[Tim Graham]

Absent a justification for the double save, this looks like invalid usage rather than a bug in Django.

[Anuranjit maindola]

@Tim Graham .
Doing any number of saves should be fine.
Can you elaborate on why is this is not a valid issue?

[Marten Kenbeek]

The issue is that you save twice with force_insert=True, without changing the value of the primary key. If you want to update the object after the first save, you need to strip the force_insert argument from **kwargs.