Opened 17 years ago
Closed 17 years ago
#6564 closed (duplicate)
USStateField - newforms - problems
| Reported by: | Purdea Andrei | Owned by: | Purdea Andrei |
|---|---|---|---|
| Component: | Uncategorized | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | purdeaandrei@… | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
The problem appears with the newforms representation of USStateField.
There was absolutely no handling for the case when blank=True. (or with other words required=False).
These modification take the implementation closer to the implementation of ModelChoiceField (the one used for ForeignKey).
- there is an empty_label parameter that is set to u'---------' by default
- i removed the specialized widget, because no such widget was needed
- modified the formfield method accordingly
This bug appears both in trunk and in the newforms-admin branch, the patch can safely be applyed to both.
Attachments (1)
Change History (4)
by , 17 years ago
| Attachment: | usstate.diff added |
|---|
comment:1 by , 17 years ago
comment:2 by , 17 years ago
| Needs tests: | set |
|---|---|
| Patch needs improvement: | set |
Note:
See TracTickets
for help on using tickets.
the diff i uploaded does not work well. it breaks regression tests, and it removes the us of USStateField formfield. - It is supposed to be used with text input, and not a select input! A separate class will be needed for the default choice input...
i am working on a new patch....
Purdea Andrei