django.views.generic.date_based.archive_{month,day}: date of first object outside interval available in template context

[Per Jonsson <poj@…>]

Ticket #2368 suggests that in django.views.generic.date_based generic views, previous_month and previous_day should reflect if there is objects in those months.

When trying to port the patch attached to #2368 to the state after the changes introduced in fixing #2433 with changeset [3457], I realised it was not entirely sensible.

The patch attached to this Ticket implements new variables in template context for django.views.generic.date_based.archive_month and django.views.generic.date_based.archive_day, previous_object_date and next_object_date, which gives the possibility to access the date of the first accessible object outside the interval in either direction.

[Per Jonsson <poj@…>]

Updated the patch as there were a bug in the original one.

[Jacob]

It's not clear to me why this is needed; can you explain what's wrong with previous_month/day?

[Per Jonsson <poj@…>]

previous_month/day is currently just the date of the month/day before the one currently shown, and doesn't tell if there are any objects there.

On use-case is that you are using allow_empty=True, and want to reference the month/day on either side of the currently displayed (to create links to empty pages, perhaps so that the user can bookmark them), but also want to link to the month/day with the closest accessible object outside the interval that is currently being shown.

It is possible that the information in previous_month/day should be changed to reflect the information my patch puts in previous_object_date, but that changes current behaviour.

[Per Jonsson <poj@…>]

The reference in the Description to #2368 should be #2386.

[Jacob]

I'm wary of further complicating generic views (they're already pretty hairy). Since you can do this with a wrapper around the generic view that sets extra_context, I think that's a better approach.