[patch]previous_month and previous_day are non-empty even if there are no objects in previous months/days

[Tyson Tate <tyson@…>]

Yes, I know this is documented behavior, but it is completely illogical.

In the django.views.generic.date_based generic views, previous_month and previous_day}} are not empty when there are no objects in previous months/days. {{{next_month and {{{next_day}} are empty when there are no next months and days, which is logical.

I'd expect previous_month and {{{previous_day}} to be empty when there are no objects in the previous months/days. How else are you supposed to implement date-based navigation?

[Tyson Tate <tyson@…>]

Minimal test case

[Pete Crosier]

I've put together a patch that I think does what you want.

archive_month now returns a next_month and previous_month only for months with objects, otherwise it returns None . This takes into account the specified year only, which seems logical (to me).

archive_day now returns a next_day and previous_day only for days with objects, otherwise it returns None . This takes into account the specified month only, which seems logical (again, to me).

Criticism fully appreciated, and please un-fix this if I shouldn't have marked it so :)

[Jacob]

Good patch, Pete!

I'm not so hot on the idea of only returning next/prev in the current year/month; seems like that would bite me in the ass when dealing with Jan 1st :). Think you could rework the patch to always return the next/prev month/day (if it exists) reguardless of current year/month?

(Oh, and marking it fixed is a little premature; we still gotta apply the patch :)

[Pete Crosier]

That was fast, and cheers for re-opening it :) I wasn't sure which way to go with the scope of returning things, but I see where you're coming from.. I'll see what I can conjure up.

[Tyson Tate <tyson@…>]

Just a note, Pete: you rule. Thanks a ton for looking at this. I was going to take a crack at it tonight, but your patch does exactly what I'm looking for (except for what Jacob mentioned, which I agree with).

This is going to make date-based navigation with the generic views a dream.

[Pete Crosier]

OK, version 2 is sorted.. it works more logically and the code is a bit cleaner too because of it.

Now it returns the closest previous/next months from the queryset from any year, if applicable. And it returns the closest previous/next days for any month/year, if applicable.

Thanks Tyson/Jacob :)

[Pete Crosier]

Works a bit more logically.

[Chris Beaven]

If the existing behaviour is "documented" as the ticket suggests, this documentation needs changing. Someone care to provide the patch for this too?

Extra credit if you could come up with some tests, but I'm not sure they are necessary.

[Chris Beaven]

Oops, I meant "accepted"

[Per Jonsson <poj@…>]

The patch no longer applies, as it's changes conflicts with changes introduced when fixing #2433.
The allow_future parameter introduced by #2433 is not honored. So patch needs improvement.

[Per Jonsson <poj@…>]

Ticket #3585 has an alternate solution to this problem.

[Jacob]

Marking duplicate (see Per's comments).