[patch] Newforms - suppress errors if no data passed in

[Chris Beaven]

It would be helpful if there was an easy way of not using errors if it's a form with no passed data

My suggestion is that if data is None when in the Form is initialized, then errors should be suppressed (this way, you could pass an empty dict still if you want the errors initially).

[Adrian Holovaty]

Is the distinction between as_ul() and as_ul_with_errors() isn't enough? What's the use-case for this?

[Adrian Holovaty]

Whoop, I meant:

Is the distinction between as_ul() and as_ul_with_errors() not enough? What's the use-case for this?

[Chris Beaven]

The problem is I have a template which wants to use a form. The form is rendered from my view. I want to pass the form through and do the work in the template.

Without the ignoring of errors, the form (pre-post) will contain validation errors.

[Chris Beaven]

Expanding: It seems to make sense that I can use the same form for the initial display, and displaying it again if there was any validation errors.

In fact, then you wouldn't need the separation of the helper functions between error and non-error versions. They can always be 'with_errors' as such. Having the two different functions is a bit naff really, as then either the view has to make the decision and pass HTML to the template, or the template has to know whether it's a fresh form or one requiring validation.

[Chris Beaven]

(ignore that newforms.patch, wrong file selected)

Here's my take on it anyway.

• Changed Form.errors to be a property (was a function) to match BoundField's format
• Removed a redundant Form.clean() function which was being replaced by the one at the end
• Form ignores errors if data == None
• Replaced the non-error checking as_table and as_ul functions with their _with_errors counterparts
• Updated tests

[Adrian Holovaty]

(In [4116]) newforms: Changed Form.errors to be a property rather than a function. Refs #3026

[Adrian Holovaty]

(In [4115]) newforms: Removed redundant declaration of Form.clean(). Thanks, SmileyChris. Refs #3026

[Adrian Holovaty]

(In [4117]) Fixed #3026 -- newforms: Form class now suppresses validation and errors if no data (or None) is passed in. Validation still happens if you pass in an empty dictionary. Also updated unit tests. Thanks, SmileyChris