Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#28020 closed Cleanup/optimization (fixed)

make GEOSGeometry.json use OGRGeometry.json again (for performance reasons)

Reported by: Sergey Fedoseev Owned by: Sergey Fedoseev
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Sergey Fedoseev)

GEOSGeometry.json was using OGRGeometry.json prior to 1.9. That was changed in #25141. Now GDAL is required (#26753) and I believe we should restore previous GEOSGeometry.json implementation for performance reasons:

In [67]: ls = LineString([(x, x) for x in range(1000)])

In [68]: %timeit ls.json
10 loops, best of 3: 42.6 ms per loop

In [69]: %timeit ls.ogr.json
100 loops, best of 3: 3.75 ms per loop

Change History (7)

comment:1 by Sergey Fedoseev, 8 years ago

Owner: changed from nobody to Sergey Fedoseev
Status: new → assigned

comment:2 by Sergey Fedoseev, 8 years ago

Description: modified (diff)

comment:3 by Claude Paroz, 8 years ago

Triage Stage: Unreviewed → Accepted

comment:4 by Sergey Fedoseev, 8 years ago

Has patch: set

​PR

comment:5 by Claude Paroz, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 12d0567a:

Fixed #28020 -- Made GEOSGeometry.json use OGRGeometry.json for better performance.

comment:7 by Tim Graham <timograham@…>, 7 years ago

In 815a0bb8:

Refs #28020 -- Removed obsolete GeometryCollection.json.

Unused since 12d0567aa5e82322543f0c0c126ba18c91a1e439.

Note: See TracTickets for help on using tickets.
Back to Top