Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#26753 closed Cleanup/optimization (fixed)

Make GDAL a hard dependency

Reported by: Claude Paroz Owned by: Claude Paroz
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Read ​https://groups.google.com/forum/#!topic/geodjango/gD0-1SMOBqU

This will allow us to simplify code in several places.

Change History (7)

comment:1 by Tim Graham, 8 years ago

To ease running the test suite by casual contributors, I think it's worth continuing to allow running the Django test suite without GDAL installed. In that case, we could skip all gis_tests instead of selectively skipping tests in that package.

comment:2 by Claude Paroz, 8 years ago

I think it's worth continuing to allow running the Django test suite without GDAL installed

Absolutely. We might replace or complement the HAS_GEOS/HAS_GDAL flags by some HAS_GEOLIBS flag.

comment:3 by Claude Paroz, 8 years ago

Owner: changed from nobody to Claude Paroz
Status: new → assigned

comment:4 by Claude Paroz, 8 years ago

Has patch: set

​PR

comment:5 by Tim Graham, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Claude Paroz <claude@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In f7a363e:

Fixed #26753 -- Made GDAL a required dependency for contrib.gis

Thanks Tim Graham for the review.

comment:7 by Tim Graham <timograham@…>, 8 years ago

In 7c6efb32:

Refs #26753 -- Removed obsolete workarounds in GIS tests for lack of GDAL.

Missed in f7a363ee1d2039824d95f35e54219e09c5af67b0.

Note: See TracTickets for help on using tickets.
Back to Top