#27851 closed Bug (invalid)
include(admin.site.urls) doesn't work on master yet
| Reported by: | Jerome Leclanche | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
According to the backwards compatibility notes: Support for passing a 3-tuple as the first argument to include() is removed.
However, admin.site.urls hasn't been updated yet to match: https://github.com/django/django/blob/1f7ca858664491589ba400419a491dd0a9af5dff/django/contrib/admin/sites.py#L279
Will the inclusion syntax for the admin change? Or will this keep working?
Change History (4)
comment:1 by , 8 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:2 by , 8 years ago
include(admin.site.urls) is a very common pattern (even documented). The urls property on the site is specifically crafted for that use case.
If it's changing it's fine but it needs better signaling then.
comment:3 by , 8 years ago
include(admin.site.urls) has raised a deprecation warning since 1.9. I suppose amending the 2.0 release notes to say, "Support for passing a 3-tuple (including admin.site.urls) as the first argument to include() is removed." (bold text added) may help.
Use syntax described in the 1.9 release notes (and in the admin docs). I don't see a reason to change things again.