#27347 closed Cleanup/optimization (duplicate)
Contributing docs: Patch vs Pull-Request
Reported by: | Thomas Güttler | Owned by: | nobody |
---|---|---|---|
Component: | Documentation | Version: | 1.10 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I don't understand why this approach gets used in the contributing docs:
git clone https://github.com/django/django.git
...
pip install -e /path/to/your/local/clone/django/
...
git diff > 24788.diff
See https://docs.djangoproject.com/en/1.10/intro/contributing/
I guess you prefer pull requests, since they are easier to handle.
Why not take this approach?
fork django to personal github account via github web gui
...
pip install -e git+https://github.com/mygithubnickname/django.git#egg=django
...
create pull request.
Change History (2)
comment:1 by , 8 years ago
Component: | Uncategorized → Documentation |
---|---|
Resolution: | → duplicate |
Status: | new → closed |
Type: | Uncategorized → Cleanup/optimization |
comment:2 by , 8 years ago
Thank you Graham. I guess only few people have the overview like you have. (and: sorry, I have not seen that this has been reported before).
Duplicate of #26708.