Stop setting the Content-Length header in ConditionalGetMiddleware
With #5897 we started setting Content-Length
in CommonMiddleware
. With #26447 we started moving conditional request handling out of CommonMiddleware
and into ConditionalGetMiddleware
. This separation of concerns is a good thing. Setting Content-Length
doesn't have anything to do with conditional requests, and I think it can be removed now that we have CommonMiddleware
as the standard place to set it.
Change History
(10)
Triage Stage: |
Unreviewed → Accepted
|
Type: |
Uncategorized → Cleanup/optimization
|
Owner: |
changed from nobody to Aleksandr Sobolev
|
Status: |
new → assigned
|
Owner: |
changed from Aleksandr Sobolev to Martino Pizzol
|
Owner: |
Martino Pizzol removed
|
Status: |
assigned → new
|
Owner: |
set to Adam Malinowski
|
Status: |
new → assigned
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
It was discussed briefly when adding
Content-Length
toCommonMiddleware
. We didn't see much advantage to removing it at the time asConditionalGetMiddleware
might be used withoutCommonMiddleware
. I don't have a strong feeling about it though.