Opened 9 years ago
Closed 9 years ago
#25116 closed Cleanup/optimization (fixed)
Remove admindocs model-based bookmarklets
| Reported by: | Ben Spaulding | Owned by: | Ben Spaulding |
|---|---|---|---|
| Component: | contrib.admindocs | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
The three admindocs bookmarklets that relate to models (show model type and id, edit in admin in this window, and in new window) have not worked since commit 64e11a6 (from ticket #13285) several years ago. There is not a simple way to make these work again, unless we re-introduce something like populate_xheaders, which is not reasonable. I think they should simply be removed. (Feel free to reject this ticket if that opinion is not shared.)
This should make #8079 moot.
Also, if #25115 lands first, we may also want to remove the logic in the admindocs bookmarklet view that adds admin_url to the context.
Change History (4)
comment:1 by , 9 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 9 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 9 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Note:
See TracTickets
for help on using tickets.
Considering that it took three Django releases (1.6 to 1.8) for someone to notice the problem, it's clear that this feature isn't used much if at all and should be purged rather than fixed.