Opened 10 years ago

Closed 10 years ago

#24440 closed Cleanup/optimization (fixed)

Debug.py could use additional padding for individual stack rows.

Reported by: Andy Matthews Owned by: nobody
Component: Core (Other) Version: 1.7
Severity: Normal Keywords: debug padding spacing
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description (last modified by Andy Matthews)

When viewing debug output, or any code which generates a stack trace, the CSS for debug.py does not contain enough padding for nested list items. This results in a dark grey border which directly touches the line of code it contains. This makes it difficult to read.

This ticket is a request, along with screenshots and patch, to add 5px of padding on two list item tags.

https://github.com/django/django/blob/c7a6996df7e77bc3b9c5e581e67d766627ebabec/django/views/debug.py#L639-L641

Attachments (3)

debug-add-padding-to-list-item.diff (996 bytes ) - added by Andy Matthews 10 years ago.
debug-screenshot-before.png (181.4 KB ) - added by Andy Matthews 10 years ago.
debug-screenshot-after.png (166.0 KB ) - added by Andy Matthews 10 years ago.

Download all attachments as: .zip

Change History (8)

by Andy Matthews, 10 years ago

by Andy Matthews, 10 years ago

Attachment: debug-screenshot-before.png added

by Andy Matthews, 10 years ago

Attachment: debug-screenshot-after.png added

comment:1 by Andy Matthews, 10 years ago

I've created a PR which

comment:2 by Andy Matthews, 10 years ago

Description: modified (diff)

comment:3 by Tim Graham, 10 years ago

Easy pickings: unset
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

The idea seems okay, although as I noted on the PR, I think 5px is a bit too much.

comment:4 by Matt Seymour, 10 years ago

3px seems to work well and its the diplomatic middle(ish) ground.

comment:5 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: newclosed

In b4da88b:

Fixed #24440 -- Added padding to debug view stacktrace lines.

Note: See TracTickets for help on using tickets.
Back to Top