Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#24439 closed Bug (fixed)

make_object_list attribute mis-used in GCBV Documentation

Reported by: jambonrose Owned by: nobody
Component: Documentation Version: 1.7
Severity: Normal Keywords: generic class-based-views
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The attribute make_object_list is defined in BaseYearArchiveView, ​on line 445 of `django/views/generic/dates.py`.

The only class to inherit from BaseYearArchiveView is YearArchiveView (​on line 485 of the same file). Therefore, the only two classes where the make_object_list are BaseYearArchiveView and YearArchiveView.

However, in addition to the two classes above, ​the reference documentation uses the make_object_list attribute on examples of:

  • MonthArchiveView
  • WeekArchiveView
  • DayArchiveView
  • TodayArchiveView

In these instances, the attribute will have no effect, but is misleading, and should be removed.

Change History (5)

comment:1 by jambonrose, 10 years ago

Has patch: set

comment:2 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In fea45eff5a2f2ad10b2788603db80e5a4fe6be06:

Fixed #24439 -- Removed incorrect make_object_list attributes in CBV docs.

comment:3 by Tim Graham <timograham@…>, 10 years ago

In edb5c9a01e0312eb23a955e13282c93d4ec9b097:

[1.7.x] Fixed #24439 -- Removed incorrect make_object_list attributes in CBV docs.

Backport of fea45eff5a2f2ad10b2788603db80e5a4fe6be06 from master

comment:4 by Tim Graham <timograham@…>, 10 years ago

In c5a8b442bdbb70cd34595f6c8c6d10bb6d038989:

[1.6.x] Fixed #24439 -- Removed incorrect make_object_list attributes in CBV docs.

Backport of fea45eff5a2f2ad10b2788603db80e5a4fe6be06 from master

comment:5 by Tim Graham <timograham@…>, 10 years ago

In ac6bc2c09072515abd70b4e3898d15cd266bc8d9:

[1.8.x] Fixed #24439 -- Removed incorrect make_object_list attributes in CBV docs.

Backport of fea45eff5a2f2ad10b2788603db80e5a4fe6be06 from master

Note: See TracTickets for help on using tickets.
Back to Top