Consider moving FlatPageSitemap to contrib.flatpages
The FlatPageSitemap currently exists within the 'core' django.contrib.sitemaps
namespace, though it's specific to django.contrib.flatpages
. Given a number of modules and moves have happened recently, I'm floating the idea of:
- Moving
FlatPageSitemap
to django.contrib.flatpages.sitemaps
, which would better reflect it's dependencies (though it still has one to django.contrib.sites
), and is more inline with how sitemaps would be packaged in third-party apps (and would allow spinning out flatpages to an external app with less work, if ever desired)
- Raising a deprecation warning for a release, if importing from the old namespace (like the ContentTypes move and form.util moves)
The documentation currently says The sitemap framework provides a couple convenience classes for common cases, and I'd argue that flatpages isn't all *that* common, these days, though it may have been in the past (before richer packages either built on it or supplanted it, because the ecosystem was smaller)
Change History
(9)
Triage Stage: |
Unreviewed → Accepted
|
Has patch: |
set
|
Owner: |
changed from nobody to Berker Peksag
|
Status: |
new → assigned
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
Has patch: |
unset
|
Resolution: |
fixed
|
Status: |
closed → new
|
Resolution: |
→ fixed
|
Status: |
new → closed
|
https://github.com/django/django/pull/3710