flatatt modifies passed in dict, possibly changing the result of subsequent calls

[Tim Heap]

The updated django.forms.utils.flatatt function modifies the dict passed in, deleting any boolean attributes it encounters. Calling the function twice using the same dict that contains boolean attributes will thus result in different output, as the boolean attributes have been deleted:

>>> attrs = {'hello': 'world', 'data-true': True, 'data-false': False}
>>> flatatt(attrs)
' hello="world" data-true'
>>> flatatt(attrs)
' hello="world"'

The function should not modify the dict passed in like it does, leaving it unchanged. Fixing this will make the function behave as expected when called with the same dict twice.

[Tim Heap]

A pull request has been created on Github: ​https://github.com/django/django/pull/3590

[Claude Paroz <claude@…>]

In 5b17dcd8ef9c444af2e0a234d708c37b313ef04f:

Fixed #23883 -- Stopped flatatt modifying its argument