Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#21613 closed Cleanup/optimization (fixed)

Misleading hardcoded input id in tutorial

Reported by: Claude Paroz Owned by: AnneTheAgile
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

https://docs.djangoproject.com/en/dev/intro/tutorial04/

That means, when somebody selects one of the radio buttons and submits the form, it’ll send the POST data choice=3.

Apparently, nothing forces the value to be 3. We should rephrase this sentence.

Change History (7)

comment:1 by Claude Paroz, 11 years ago

Oh, credit to Bruno Brouard for spotting this issue.

comment:2 by AnneTheAgile, 11 years ago

Owner: changed from nobody to AnneTheAgile
Status: newassigned

comment:3 by AnneTheAgile, 11 years ago

See Pull Request,
https://github.com/django/django/pull/2078
My comment #21613 , Clarified the previously mysterious magic constant '3'. I researched a bit and there are '3' default choices available, https://docs.djangoproject.com/en/dev/intro/tutorial02/ .

comment:4 by Tim Graham <timograham@…>, 11 years ago

Resolution: fixed
Status: assignedclosed

In cc2d9602746395d5f406632139378d469ca6301b:

Fixed #21613 -- Removed a hardcoded input id from the tutorial.

Thanks Bruno Brouard for the report.

comment:5 by Tim Graham <timograham@…>, 11 years ago

In 6980059af2835ed3d15b4a59e16321bc8d828c0e:

[1.5.x] Fixed #21613 -- Removed a hardcoded input id from the tutorial.

Thanks Bruno Brouard for the report.

Backport of cc2d960274 from master

comment:6 by Tim Graham <timograham@…>, 11 years ago

In 07d3d57dedbc2baf8d704d32f3d48523d2991b9e:

[1.6.x] Fixed #21613 -- Removed a hardcoded input id from the tutorial.

Thanks Bruno Brouard for the report.

Backport of cc2d960274 from master

comment:7 by AnneTheAgile, 11 years ago

yay, I'm glad the fix is approved. I was thinking of just writing "#" as done in the accepted change, but thought maybe it wouldn't be accepted and so was trying to rewrite the text around it. I deleted my branch. Thank you for your patience with me and question-answering !

Note: See TracTickets for help on using tickets.
Back to Top