Opened 12 years ago
Closed 12 years ago
#20067 closed Cleanup/optimization (invalid)
Managet Queryset Typo
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The documentation method to override the default Model Manager queryset is incorrect in the dev version. This method begins to appear after Modifying Initial Manager QuerySets (https://docs.djangoproject.com/en/dev/topics/db/managers/#modifying-initial-manager-querysets), and continue throughout the page.
Incorrect version
Manager.get_queryset()
Correct version
Manager.get_query_set()
I confirmed this appears correctly in v1.4 and v1.5 documentation. The error is only in the dev version.
Change History (2)
comment:1 by , 12 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Type: | Uncategorized → Cleanup/optimization |
| Version: | 1.5 → master |
comment:2 by , 12 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
The versionchanged directive is already there: https://github.com/django/django/commit/6983a1a540a6e6c3bd941fa15ddd8cb49f9ec74e#L21R178
Note:
See TracTickets
for help on using tickets.
The method's name has been changed for consistency throughout Django. In 1.5 and earlier methods/properties were sometimes spelled query_set but in most places queryset. So, get_query_set has been renamed to get_queryset in the development version.
I think a versionchanged note in there would be useful, so marking as accepted.