Opened 15 years ago
Closed 15 years ago
#12492 closed (fixed)
Three new literals in djangojs message file
| Reported by: | Ramiro Morales | Owned by: | Jannis Leidel |
|---|---|---|---|
| Component: | Internationalization | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Since r11964 and r12030 the 'FIRST_DAY_OF_WEEK', 'TIME_INPUT_FORMATS' and 'DATE_INPUT_FORMATS' literals are being picked up by makemessages when running it over the djangojs domain.
Reason is we are wrapping them with a gettext call, but what we really want is the runtime behavior (having these taken from the Javascript i18n catalog) without they appearing in the djangojs.po files because 1) if the translator translates them these transalation override what is specified in formats.py (possibly customized by the deployer, 2) we are forcing him/her to maintain the same translations in two places and 3) Conversely, if nobody translates them in djangojs.po then the respective formats specified in the relevant formats.py aren't being applied either.
Change History (2)
comment:1 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [12081]) Fixed #12492 - Refactored JavaScript format localization by separating it from the translation backend. Thanks, Ramiro Morales.