Opened 15 years ago

Closed 11 years ago

#12491 closed Bug (fixed)

help_text for checkbox badly aligned if not on its own line

Reported by: master Owned by: Ramiro Morales
Component: contrib.admin Version: 1.1
Severity: Normal Keywords: help_text design_ux
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Ramiro Morales)

help_text is badly aligned under its checkbox when not alone on the line.

Due to media/css/forms.css:

If the chekbox is on its own line: .checkbox-row p.help applies, with a padding-left: 0, it's ok.

Otherwise: form .aligned p.help applies, with a padding-left: 38px, which gives an ugly rendering.

Attachments (1)

48.png​ (13.8 KB ) - added by Ramiro Morales 11 years ago.
Checkbox help text layout before the proposed fix.

Download all attachments as: .zip

Change History (13)

comment:1 by Russell Keith-Magee, 15 years ago

Keywords: design_ux added
Triage Stage: Unreviewed → Accepted

comment:2 by Matt McClanahan, 14 years ago

Severity: → Normal
Type: → Bug

comment:3 by Julien Phalip, 13 years ago

UI/UX: set

comment:4 by Aymeric Augustin, 13 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 by Aymeric Augustin, 13 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:6 by Aymeric Augustin, 13 years ago

UI/UX: set

Revert accidental batch modification.

comment:7 by Niels van Dijk, 12 years ago

I have written a patch for this ticket: ​https://github.com/django/django/pull/771

Styling was already their but the class name was not used in any template. In admin forms, the help text of a checkbox field will start at the beginning of the line. No indentation. See screenshot:

http://i48.tinypic.com/24fms69.png

comment:8 by Claude Paroz, 12 years ago

Has patch: set

comment:9 by Ramiro Morales, 12 years ago

Owner: changed from nobody to Ramiro Morales
Status: new → assigned

comment:10 by Ramiro Morales, 11 years ago

Description: modified (diff)

by Ramiro Morales, 11 years ago

Attachment: 48.png​ added

Checkbox help text layout before the proposed fix.

comment:11 by Ramiro Morales, 11 years ago

This screen capture shows the alignment of the help text before the fix proposed by nvandijk:

Checkbox help text layout before the proposed fix.

comment:12 by Ramiro Morales <cramm0@…>, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 7a923128278e9e07cd8e7ca50400ba24617825dd:

Fixed #12491 -- Tweak checkbox widget help text alignment on the admin.

Thanks master' for the report and Niels van Dijk for the fix

Note: See TracTickets for help on using tickets.
Back to Top