Made month and year selectable in admin calender widget.

[Fidel Ramos]

My colleague Javier de la Rosa has enhanced the calendar shown in admin's date fields to allow navigation through years, and not only through months. This requires changing calendar.js and DateTimeShortcuts.js.

We have chosen not to maintain backwards compatibility because this should be a feature in Django 1.1, but it's easy to do if required.

Javier de la Rosa will attach his patch later.

[Javier de la Rosa]

Patch for django trunk r9232

[Javier de la Rosa]

Patch added.
If backwards compatibility is required, I can send a new patch with the proposal, it's done but I chose not to include it.

[(none)]

Milestone post-1.0 deleted

[Ramiro Morales]

patch updated to apply cleanly to trunk as of r12089.

[Ramiro Morales]

Patch has been updated to current trunk status. Modified to keep current element class names for month navigation unmodified and add brand new "-year"-suffixed names for elements involved in year navigation. This is what interpret is what the OP was talking about when he said 'backward compatibility'.

(Wrong ticket number in patch file name is a typo.)

[Ramiro Morales]

See also #2889 that proposed the same thing.

[Ramiro Morales]

#6487 proposed the same and also contains a patch.

[Tay Ray Chuan]

ramiro: I closed the tickets you referenced as related; that way, we can focus out attention of this ticket.

[Ramiro Morales]

Patch updated to r16225

[lawgon@…]

I tried this patch on the latest trunk (had to do it manually as the directory structure has changed.) Nothing happened, the widget is unchanged.

[Aymeric Augustin]

This sounds useful, I don't know which design decision was expected.

[Tomek Paczkowski]

Unfortunately, patch no longer applies.

[Mariusz Felisiak]

​PR

[Alexander Lazarević]

I just looked at this and the PR seemed to have gotten pretty far. Patch still works with the current main branch.

Now two years have passed and I'm not sure what was/is blocking this.

• needs tests? The PR includes the following tests (are more needed?):
  • test_show_hide_month_picker_widgets
  • test_month_picker_selected_class_and_input
  • test_month_picker_prev_next_links
  • test_show_hide_year_picker_widgets
  • test_year_picker_selected_class_and_input
• needs documentation? The PR changed docs/releases/4.1.txt to contain:

  Now admin calendar caption is selectable and opens monthlist and yearlist. now it's easy adding older dates like birthday via admin calendar widget
  

  • I briefly checked the following docs and the calendar description seemed to be still in in sync with what the PR would introduce
    • intro/tutorial02.txt
    • ref/contrib/sitemaps.txt
    • ref/models/fields.txt
    • ref/settings.txt
    • topics/forms/index.txt
    • topics/forms/media.txt
    • topics/i18n/timezones.txt
• patch needs improvement? As far as I can tell from the PR, every request or recommendation was integrated?
• decision to use native datepicker instead is still pending?
• decision to use some other datepicker package instead is still pending?
• something else?

[Thibaud Colas]

Yes, I would say a big problem here is that this builds upon a date picker widget which we already know has many accessibility flaws and needs a replacement (see ​Refs #29822 -- Improved date, time and datetime HTML inputs #15806). Personally I wouldn’t recommend working on that widget, but if others think incremental improvements are the path forward that’s a valid call too.

Aside from that – there is also one code review comment on the PR which the author has yet to address.

[Alexander Lazarević]

Replying to Thibaud Colas:

Yes, I would say a big problem here is that this builds upon a date picker widget which we already know has many accessibility flaws and needs a replacement

Ok, that wasn't apparent to me. Thanks for the clarification.

[Tim Graham]

Closing as "wontfix" might be appropriate but nothing has been fixed as far as I see.