file storage should allow saving of basic file-like objects

[jaboja@…]

It is not possible to save file opened by urllib2.urlopen into field of a model.
When trying to do that following way:

f = File(urlopen("​http://something.com/somefile.ext").fp)
MODEL.FIELD.save("name.ext", f, save=False)

Django throws AttributeError: '_fileobject' object has no attribute 'seek'

Probeably django\core\files\base.py on line checks if class has attribute seek, but it is being definied at line 125 even when constructor gets an object that does not have such attribute (like urllib2.addinfourl.fp which is socket._fileobject).

[daonb <bennydaon@…>]

Patch 8501v1.diff supports passing the result of a urlopen as the content parameter for the save method of FileField and ImageField. Here's the included testing code:

>>> obj5 = Storage()
>>> image_data_len = len(urlopen('http://media.djangoproject.com/img/badges/djangosite80x15.gif').read())
>>> obj5.image.save('django_logo.gif',urlopen('http://media.djangoproject.com/img/badges/djangosite80x15.gif'))
>>> obj5.image
<ImageFieldFile: tests/django_logo.gif>
>>> image_data_len == obj5.image.size
True
>>> obj5.image.width
80L
>>> obj5.image.height
15L

[Chris Beaven]

Interesting. It seems this is more useful than just for urlopen - it allows saving file objects (and stringio streams) directly too. In fact, I'd write urlopen off as a side-effect and rejigg the patch tests to just use open()

[(none)]

Milestone post-1.0 deleted

[Adam Nelson]

I believe using ContentFile already handles this case:

source:django/trunk/django/core/files/base.py

Feel free to reopen if not.

[Mikhail Korobov]

I think ContentFile doesn't fully cover this case because it needs a whole file loaded to memory and it should be possible to avoid this.

[Collin Anderson]

This has been fixed via duplicate ticket #15644.