dates() querysets don't work after qsrf

[fcaprioli@…]

After queryset refactor merge, a .dates() DateQueryset won't work on a null=True DateField.

During query setup, the queryset adds a .filter(fieldname__isnull=True) instead of .filter(fieldname__isnull=False) to avoid parsing null dates, so the resulting sql returns an empty list (or raise errors if there actually are null fields in the db).

I've attached a patch that fixes the problem

[oyvind]

Spread across 3 tickets #7145, #7147

[Alex Gaynor]

I'm marking this as accepted, and the patch makes sense, however it would be nice if we could add a testcase for this regression.

[Jeremy Dunck]

Updated patch with regression test included.

[fcaprioli@…]

I've been using the patched code in a fairly complex app (production server, a few million pages etc) without any problem; now that it includes tests (thank you jeremy!), this can be probably checked in even before malcolm's return. Any core dev interested? It is, after all, an harmless on-liner :)

[George Vilches]

Non-core devs should not mark things as ready for checkin.

[Karen Tracey <kmtracey@…>]

#7199 marked as a dup of this.

[Karen Tracey <kmtracey@…>]

Bumping back up to ready for checkin based on Russell's note to django-dev:

​http://groups.google.com/group/django-developers/msg/e8762784813b3921

where he says "If a ticket describes something that is clearly a bug, move to accepted (or ready for checkin if it's a trivial problem with a patch and tests ready to go)."

I think this one fits the "trivial" category and it has a test. It looks like at least 4 people have hit this bug and reported it in the tracker so it would be nice to have the very minor and obvious fix get into the code base.

[Russell Keith-Magee]

(In [7739]) Fixed #7155 -- Corrected DateQuerySet to handle nullable fields. Thanks to fcaprioli@… for the original report and patch, and to Jeremy Dunck for the test case.

[Jacob]

Milestone 1.0 deleted