Decimal validation doesn't correctly handle max_digits == decimal_places

[Craig Ogg]

If you have a decimal field defined in a model with max_digits and decimal_places set to the same value (for values 0 <= |n| < 1), you will get the following error message incorrectly when you enter any valid value:

• Please enter a valid decimal number with a whole part of at most 0 digits.

You will also get the following error message incorrectly if the number you enter has decimal_places number of digits:

• Please enter a valid decimal number with at most %s total digits.

This is because the leading 0 that str() produces is considered a digit in the validation code (e.g., .35 and 0.35 are treated as 3 digit numbers, with 0 as a digit in the "whole part").

[Craig Ogg]

Corrected patch

[Marc Fargas]

The patch should include a test that demostrates this behaviour (and that it's solved). I'll upload it in a while if you don't mind.

[Marc Fargas]

added test.

[Marc Fargas]

Added a test case.

[Karen Tracey]

The code involved here is gone now but the problem still exists in form validation. max_digits == decimal_places is perfectly valid at the database level so Django should support it. As it is now you cannot bring up an existing valid decimal field defined in this way to the DB and simply re-save it using the admin interface.

[Karen Tracey]

(In [9387]) Fixed #7064: Made DemicmalField validation support max_digits equal to decimal_places.

[Karen Tracey]

(In [9389]) [1.0.X] Fixed #7064: Made DemicmalField validation support max_digits equal to decimal_places.

r9387 and r9388 from trunk.