ConditionalGetMiddleware doesn't set response code properly

[DOP]

Just noticed that If-None-Match request doesn't really work even though ConditionalGetMiddleware is enabled and the response has ETag matching If-None-Match header in the request.

This is from django/middleware/http.py:

        if response.has_header('ETag'):
            if_none_match = request.META.get('HTTP_IF_NONE_MATCH', None)
            if if_none_match == response['ETag']:
...
                response.status = 304

        if response.has_header('Last-Modified'):
            if_modified_since = request.META.get('HTTP_IF_MODIFIED_SINCE', None)
            if if_modified_since == response['Last-Modified']:
...
                response.status = 304

Shouldn't it be response.status_code = 304?

[Eratothene]

I have just checked it. Indeed it should be response.status_code = 304

[Simon Greenhill]

Yep, should be status_code. I think what's happened is that the Request/Response attribute is status_code, the parameter given to set it in __init__ is status, which has confused the person who added that code (it certainly confused me - I've opened #7453 to track this additional issue.

[Malcolm Tredinnick]

(In [7793]) Fixed #7046 -- set the response status code correctly in ConditionalGetMiddleware.