Opened 17 years ago

Closed 14 years ago

Last modified 14 years ago

#6750 closed (fixed)

Invalid xhtml in AdminFileWidget (target="_blank")

Reported by: Marc Garcia Owned by:
Component: contrib.admin Version: newforms-admin
Severity: Keywords: admin invalid xhtml AdminFileWidget nfa-someday
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As requested in #5695, here is the fix for the invalid xhtml in the AdminFileWidget. It's just a target="_blank" replaced by the javascript open.window().

May be I could develop another patch changing string variables by a dictionay to make the code clearer.

Attachments (1)

6750.diff​ (829 bytes ) - added by Marc Garcia 17 years ago.
Patch for the ticket (without a dictionary as string variables)

Download all attachments as: .zip

Change History (9)

by Marc Garcia, 17 years ago

Attachment: 6750.diff​ added

Patch for the ticket (without a dictionary as string variables)

comment:1 by Jacob, 17 years ago

Triage Stage: Unreviewed → Design decision needed

Hm. I'm not sure I like doing this all that much -- embedding Javascript in HTML in Python feels super yucky. Personally, I'm OK with the invalid XHTML as long at it works.

comment:2 by Marc Garcia, 17 years ago

Keywords: fs-rf added

What about simply removing the target="_blank", or moving the javascript to a .js file?

It's supposed to be a framework for perfectionists, we shouldn't leave the invalid code in there... ;)

comment:3 by Karen Tracey <kmtracey@…>, 17 years ago

Keywords: nfa-someday added

Jacob's comment makes me think this is not critical to be addressed before nfa merge?

comment:4 by Marty Alchin, 17 years ago

Keywords: fs-rf removed

The filestorage refactor has nothing to do with widgets, much less anything admin-specific, so I'm removing the fs-rf keyword.

comment:5 by Marc Garcia, 16 years ago

Owner: changed from nobody to Marc Garcia

comment:6 by Marc Garcia, 15 years ago

Owner: Marc Garcia removed

comment:7 by Julien Phalip, 14 years ago

Resolution: → fixed
Status: new → closed

Things have changed since 3 years ago and I now can't find any occurrence of target="_blank" in the code, so let's consider this as fixed.

comment:8 by Łukasz Rekucki, 14 years ago

Just for reference, (x)HTML 5 no longer deprecates target="_blank".

Last edited 14 years ago by Łukasz Rekucki (previous) (diff)
Note: See TracTickets for help on using tickets.
Back to Top