Opened 17 years ago

Closed 17 years ago

Last modified 13 years ago

#6718 closed (fixed)

ImportError at /admin/logout/

Reported by: Eric B <ebartels@…> Owned by: nobody
Component: Contrib apps Version: newforms-admin
Severity: Keywords: auth importerror logout nfa-blocker
Cc: post@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

I'm getting an ImportError at /admin/logout/

Traceback:
File "/home/mrmelve/dev/python-local/django/core/handlers/base.py" in get_response
  82.                 response = callback(request, *callback_args, **callback_kwargs)
File "/home/mrmelve/dev/python-local/django/contrib/admin/sites.py" in root
  113.             return self.logout(request)
File "/home/mrmelve/dev/python-local/django/contrib/admin/sites.py" in logout
  197.         from django.contrib.auth.views import logout
File "/home/mrmelve/dev/python-local/django/contrib/auth/views.py" in <module>
  1. from django.contrib.auth.forms import AuthenticationForm
File "/home/mrmelve/dev/python-local/django/contrib/auth/forms.py" in <module>
  1. from django.contrib.auth.models import User
File "/home/mrmelve/dev/python-local/django/contrib/auth/models.py" in <module>
  369. from django.contrib.auth import admin
File "/home/mrmelve/dev/python-local/django/contrib/auth/admin.py" in <module>
  1. from django.contrib.auth.forms import UserCreationForm

Exception Type: ImportError at /admin/logout/
Exception Value: cannot import name UserCreationForm

This looks like a circular import problem in contrib.auth.admin.
From the traceback, importing User imports admin which imports UserCreationForm which imports User again.
Oddly, I haven't experienced this error using the development server, but only when running under mod_python. Also, the problem is somewhat intermittent in that sometimes the logout completes without a problem, but most of the time triggers the import error.

I've attached a patch which avoids the problem by moving the import of UserCreationForm from the top level into the add_view method.

Attachments (1)

logout_importerror.diff​ (716 bytes ) - added by Eric B <ebartels@…> 17 years ago.

Download all attachments as: .zip

Change History (9)

by Eric B <ebartels@…>, 17 years ago

Attachment: logout_importerror.diff​ added

comment:1 by Jacob, 17 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Bela Hausmann <post@…>, 17 years ago

Cc: post@… added

comment:3 by Michael Newman, 17 years ago

Patch needs improvement: set

I believe this error is due to an AlreadyRegistered exception and it will be fixed when that is handled differently. That being said if it is the AlreadyRegistered exception, this patch is really not the way to fix it. Also, I am only able to duplicate this in mod_python; in the runserver environment it doesn't seem to through the error. I think that this error and some other odd AlreadyRegistered errors are due to the way mod_python handles imports.

comment:4 by mariarchi, 17 years ago

It also happens to me when I'm trying to log in (mod_python, worker mpm).
Also, why this ticket is not marked as nfa-blocker?

comment:5 by mrts, 17 years ago

Keywords: nfa-blocker added

Marking as nfa-blocker. This clearly needs to be fixed one way or other before nfa can be merged.

comment:6 by Marc Garcia, 17 years ago

milestone: → 1.0 alpha

comment:7 by Brian Rosner, 17 years ago

Resolution: → fixed
Status: new → closed

(In [7671]) newforms-admin: Fixed #6718 -- Removed a circular import in contrib/auth/admin.py. Thanks Eric B.

comment:8 by Jacob, 13 years ago

milestone: 1.0 alpha

Milestone 1.0 alpha deleted

Note: See TracTickets for help on using tickets.
Back to Top