max_num, etc. for inline models in newforms-admin

[Yves Serrano]

The max_num feature is missing in the newforms-admin branch. When you add max_num to your Child_Inline max_num doesn't do anything.

from django.contrib import admin 
class Child_Inline(admin.TabularInline): 
    model = Child 
    extra = 3 
    max_num = 5

I looked at the code in django/contrib/admin/options.py and it seems that there is no max_num feature there.

I added a patch with the missing functionality. I'm not sure if it's the best way to do it, especially the line with apply in it.

[Karen Tracey <kmtracey@…>]

It doesn't look like any of the (max_num_in_admin, min_num_in_admin, num_extra_on_change, num_in_admin) described in the old admin doc (here: ​http://www.djangoproject.com/documentation/model-api/#many-to-one-relationships) have been implemented in newforms-admin. Rather than adding them one at a time it would make more sense to have one ticket cover them all. Marking this blocking on merge since it's a loss of capability from old admin. When implemented doc will be needed to describe any changes in the names of these things, and tests would be good too.

[Jakub Wiśniowski]

Updated patch for django version 7363 (should work for versions from 7270)

[brooks.travis@…]

Seems like whatever is done to add this feature to the admin should probably be abstracted to the InlineFieldset portion of newforms, rather than living in contrib.admin, as it would be just as useful there.

[Brian Rosner]

(In [7613]) newforms-admin: Fixed #6075 -- Implemented max_num on formsets and model formsets. Added a hook on InlineModelAdmin to customize in the admin interface.