#6004 closed (fixed)
Useless code in newforms admin
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | Keywords: | nfa-blocker | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
There is too much not used code in newforms admin. It is quite difficult to understand django.contrib.admin if there are many obsolete things. I don't feel it is useful as documentation - there are too many changes and almost everything is ported now.
For example:
- urls.py - replaced by sites.ModelAdmin.root and options.ModelAdmin.call
- templates.widget - replaced by widgets.py
- almost everything in templatetags.admin_modify and views.main.AdminBoundField - replaced by widgets.py and wrappers from options
- views.main.model_admin_view and views.main.index - moved to sites.ModelAdmin
Attachments (4)
Change History (12)
by , 17 years ago
| Attachment: | 00-admin-useless-code.diff added |
|---|
by , 17 years ago
| Attachment: | 00-admin-useless-code.2.diff added |
|---|
comment:1 by , 17 years ago
by , 17 years ago
| Attachment: | 00-admin-useless-code.3.diff added |
|---|
new version - after autoescape merge
comment:2 by , 17 years ago
| Keywords: | nfa-blocker added |
|---|
I think it would make sense to clean things up before merge, so I'm marking this blocking. TPTB can of course feel free to disagree & override.
comment:3 by , 17 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
Decision needed - it's been 4 months since these diff's were submitted, perhaps they are no longer relevant to the currnt SVN branch of NFA?
comment:4 by , 17 years ago
| milestone: | → 1.0 alpha |
|---|
by , 17 years ago
| Attachment: | 00-admin-useless-code.4.diff added |
|---|
comment:6 by , 17 years ago
| Triage Stage: | Design decision needed → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
I don't know why but my patch is not showed by trac. It can be download as original format.