#5628 closed (fixed)
[newforms-admin] - when an inline formset has errors, no message is displayed at the top of the form
| Reported by: | Brian Rosner | Owned by: | jkocherhans |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | Keywords: | nfa-blocker | |
| Cc: | framos@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
If an inline formset has any validation errors then the error message Please correct the errors below. won't be displayed at the top of the form.
Attachments (3)
Change History (12)
comment:1 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
by , 17 years ago
| Attachment: | 5628_formset_errors_fix.diff added |
|---|
comment:2 by , 17 years ago
by , 17 years ago
| Attachment: | 00-admin-errors added |
|---|
comment:3 by , 17 years ago
Another version of patch - I think it is necessary to count all errors. So it can be chosen if "Please correct the error below." or "Please correct the errors below." should be used.
comment:4 by , 17 years ago
| Keywords: | nfa-blocker added |
|---|
Ah, much better patch than mine with the hacked up code ;) Marking as nfa-blocker.
comment:5 by , 17 years ago
| Has patch: | set |
|---|
comment:6 by , 17 years ago
| Cc: | added |
|---|
comment:7 by , 17 years ago
| milestone: | → 1.0 alpha |
|---|
Note:
See TracTickets
for help on using tickets.
I have attached a patch that I am using to solve this problem. Not the best patch, some cleanup work is needed, but nonetheless it works. My apolozigies if anything is wrong with the patch since I am still trying to improve my life with SVK slowly, but surely ;)