{% blocktrans %} does not escape % in text

[nostgard <nostgard@…>]

When you try to use a blocktrans with a percent sign in it. When the percent is escaped (%%) it renders fine. It does not occur when using a trans tag.

>>> from django.template import Context, Template
>>> t1 = Template('{% load i18n %}{% blocktrans %}We lost 5% today.{% endblocktrans %}')
>>> t2 = Template('{% load i18n %}{% blocktrans %}We lost 5%% today.{% endblocktrans %}')
>>> t3 = Template('{% load i18n %}{% trans "We lost 5% today." %}')
>>> c = Context()
>>> t1.render(c)
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "D:\Python\lib\site-packages\django\template\__init__.py", line 181, in render
    return self.nodelist.render(context)
  File "D:\Python\lib\site-packages\django\template\__init__.py", line 736, in render
    bits.append(self.render_node(node, context))
  File "D:\Python\lib\site-packages\django\template\__init__.py", line 764, in render_node
    raise wrapped
TemplateSyntaxError: Caught an exception while rendering: unsupported format character 't' (0x74) at index 11

Original Traceback (most recent call last):
  File "D:\Python\lib\site-packages\django\template\__init__.py", line 754, in render_node
    result = node.render(context)
  File "D:\Python\lib\site-packages\django\templatetags\i18n.py", line 73, in render
    result = translation.ugettext(singular) % context
ValueError: unsupported format character 't' (0x74) at index 11

>>> t2.render(c)
u'We lost 5% today.'
>>> t3.render(c)
u'We lost 5% today.'

[permonik@…]

Blocktrans creates template string with %()s, but doesn't correctly escape % signs in original text. Patch attached, make-messages.py works as intended - so no other harm in i18n machinery.

[Malcolm Tredinnick]

(In [6565]) Fixed #4982 -- Fixed handling of '%' symbols in 'blocktrans' blocks. Thanks,
permonik@….

[nasmon]

On Django 1.2.1:
When using single % inside blocktrans, "django-admin.py makemessages" won't work and as %% inside the template, the output still is %%, due to the patch above. When removing the patch line, everything works ok.

[Tomáš Kopeček]

Replying to nasmon:

On Django 1.2.1:
When using single % inside blocktrans, "django-admin.py makemessages" won't work and as %% inside the template, the output still is %%, due to the patch above. When removing the patch line, everything works ok.

Can you attach some working example? For me is everything working ok with 1.2.1 tree.

[Malcolm Tredinnick]

I can't repeat this problem, either. Closing for now. Please open a new ticket if there's a specific failure case, because we're not going to revert this change -- at the time it was applied, it fixed a concrete problem -- so it's a matter of tweaking the current code to fix things if there's a concrete failure case.

Reclosing as "fixed" to restore previous state.

[Claude Paroz]

FYI, I've reopened the issue with patch/test case in #16721.

[Shailen Sobhee]

The bug is still present in Django 1.5.2