Opened 16 hours ago
Last modified 4 hours ago
#36247 new Cleanup/optimization
BaseGeometryWidget unncessarily writes an error log when deserializing malformed geometry
| Reported by: | David Buhler | Owned by: | |
|---|---|---|---|
| Component: | GIS | Version: | 4.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Claude Paroz | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The following bit of error logging happens during deserialization of malformed geometry:
https://github.com/django/django/blob/stable/4.2.x/django/contrib/gis/forms/widgets.py#L55
I believe this is more appropriate as a warning or debug log as returning a None value will result in a validation error rather than a failed request. This will create noise when looking for error logs that need to be actioned on.
This also impacts the 5.2.x branch.
Change History (3)
comment:1 by , 6 hours ago
| Cc: | added |
|---|
comment:2 by , 6 hours ago
comment:3 by , 4 hours ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Note:
See TracTickets
for help on using tickets.
I'm fine with the idea to change the log severity to warning or debug.