bulk_create() update_fields argument accepts fields participating in a composite primary key

[Jacob Walls]

bulk_create() ​rejects primary key fields provided to the update_fields argument. I think I would expect any fields participating in a composite primary key to also be subject to that constraint.

Failing test:

tests/composite_pk/test_create.py

@@ -77 +77 @@
         self.assertEqual(obj_3.pk, (obj_3.tenant_id, obj_3.id))
         self.assertEqual(obj_3.email, "user8214@example.com")
 
+    def test_bulk_create_user_with_disallowed_update_fields(self):
+        objs = [User(tenant=self.tenant, id=8291, email="user8291@example.com")] * 2
+        msg = "bulk_create() cannot be used with primary keys in update fields"
+        with self.assertRaisesMessage(ValueError, msg):
+            User.objects.bulk_create(
+                objs,
+                update_conflicts=True,
+                update_fields=["tenant_id"],
+                unique_fields=["id", "tenant_id"],
+            )
+        # instead produces:
+        # [<User: User object ((1, 8291))>, <User: User object ((1, 8291))>]
+
     def test_get_or_create_user(self):
         test_cases = (
             {

[Simon Charette]

Looks like a straightforward change to _check_bulk_create_options

[Jacob Walls]

​PR