Opened 21 hours ago
Closed 18 hours ago
#36023 closed Bug (needsinfo)
Update content_disposition_header to handle control chars.
| Reported by: | Alex Vandiver | Owned by: | |
|---|---|---|---|
| Component: | HTTP handling | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
content_disposition_header does not correctly handle newlines and other control characters in values that are given to it.
See https://github.com/django/django/pull/18890 for a fix.
Change History (1)
comment:1 by , 18 hours ago
| Component: | Uncategorized → HTTP handling |
|---|---|
| Resolution: | → needsinfo |
| Status: | new → closed |
| Type: | Uncategorized → Bug |
| Version: | 5.1 → dev |
Note:
See TracTickets
for help on using tickets.
Hello Alex, thank you for taking the time to create this report. I have seen the PR but I think this ticket need more background information about why this change is needed. What I mean is that the PR shows the *what*, but in order to accept the ticket, we need to understand the *why*.
I'll close as
needsinfobut please reopen when you can provide a use case describing the need/issue being solved. A small Django project or a way to trigger the bug would also help. Thanks again!