Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#35841 closed Bug (fixed)

Regression of support for DB-IP databases in django.contrib.gis.geoip2

Reported by: Nick Pope Owned by: Nick Pope
Component: GIS Version: 5.1
Severity: Release blocker Keywords: geoip2, db-ip
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Nick Pope)

#33442 added support for using the DB-IP Lite databases.

According to this comment this support has regressed.

Various changes were made in Django 5.1 to modernise django.contrib.gis.geoip2 and improve testing, but the support for DB-IP Lite databases was missed as there were no tests for it, likely due to the prior issues around shipping test databases that was resolved as part of those changes.

Regression in 40b5b1596f7505416bd30d5d7582b5a9004ea7d5.

Change History (10)

comment:1 by Nick Pope, 2 months ago

Triage Stage: Unreviewed → Accepted

Accepting as I'm migrating this from the original issue (where it has been accepted) as per this comment.

comment:2 by Nick Pope, 2 months ago

Description: modified (diff)

comment:3 by Nick Pope, 2 months ago

Has patch: set

​PR

comment:4 by Natalia Bidart, 2 months ago

Triage Stage: Accepted → Ready for checkin

comment:5 by nessita <124304+nessita@…>, 2 months ago

In c37f249f:

Refs #35841 -- Updated GeoIP2 test database files.

The mmdb files were taken from
​https://github.com/maxmind/MaxMind-DB/commit/679e37e18a4a3009949c2213ec2c0bb8090c10c7.

comment:6 by nessita <124304+nessita@…>, 2 months ago

In 5873f10:

Refs #35841 -- Adjusted GeoIP2 tests for easier test case extension.

These changes will make it easier to introduce tests for alternate
databases that may have different results without the need to duplicate
lots of the tests definition.

comment:7 by nessita <124304+nessita@…>, 2 months ago

Resolution: → fixed
Status: assigned → closed

In 3fad712a:

Fixed #35841 -- Restored support for DB-IP databases in GeoIP2.

Thanks Felix Farquharson for the report and Claude Paroz for the
review.

Regression in 40b5b1596f7505416bd30d5d7582b5a9004ea7d5.

Co-authored-by: Natalia <124304+nessita@…>

comment:8 by Natalia <124304+nessita@…>, 2 months ago

In d1b63c2:

[5.1.x] Refs #35841 -- Updated GeoIP2 test database files.

The mmdb files were taken from
​https://github.com/maxmind/MaxMind-DB/commit/679e37e18a4a3009949c2213ec2c0bb8090c10c7.

Backport of c37f249ffa4b735d1492cda11981dedb947ee437 from main.

comment:9 by Natalia <124304+nessita@…>, 2 months ago

In 434cf00:

[5.1.x] Refs #35841 -- Adjusted GeoIP2 tests for easier test case extension.

These changes will make it easier to introduce tests for alternate
databases that may have different results without the need to duplicate
lots of the tests definition.

Backport of 5873f10177ebda66d38e698218cf85dc6397e7d9 from main.

comment:10 by Natalia <124304+nessita@…>, 2 months ago

In 51eb6667:

[5.1.x] Fixed #35841 -- Restored support for DB-IP databases in GeoIP2.

Thanks Felix Farquharson for the report and Claude Paroz for the
review.

Regression in 40b5b1596f7505416bd30d5d7582b5a9004ea7d5.

Co-authored-by: Natalia <124304+nessita@…>

Backport of 3fad712a91a8a8f6f6f904aff3d895e3b06b24c7 from main.

Note: See TracTickets for help on using tickets.
Back to Top