Plus icon should be right of text for adding an inline item in admin for RTL support

[Mario Munoz]

When using an RTL language in the Django admin, the icon for the "add" item links should appear on the left, like it does on the nav sidebar.

However, when adding inline items from the main pane, the "+" icon appears on the left side, which is counter-intuitive.

The css applied to this item should match what is being used for the nav sidebar items.

[Sarah Boyce]

LTR - Plus icon always left of the link text

RTL - Plus icon inconsistent and agree that it should always be on right of the text

[Mario Munoz]

There was no CSS class specified for the link created within the "add-row" element generated by the inline.js file. Also found duplication of the CSS that generates the icon for "addlink" icon. It was in both the base.css file as well as the forms.css file, although the forms.css also had a font-size property.

With no changes to the CSS, the addlink class had no effect on the affected element because of the duplication and CSS specificity rules. (The rule in forms.css had higher precedence.)

We standardized the usage of the addlink class by removing the css rule in forms.css for tabular and stacked elements. There was an additional property set for ul elements, but that is being addressed in ticket #35804.

By removing the css rules in forms.css and adding the class addlink class in the affected element, it is now displaying correctly, and should be easier to maintain in the future.

See screenshot for fix.

[Sarah Boyce <42296566+sarahboyce@…>]

In ef56e1f:

Fixed #35799 -- Fixed the positioning of the inline admin plus icon for RTL languages.