Opened 6 months ago
Closed 5 months ago
#35546 closed Cleanup/optimization (fixed)
Modernize contributing pages to align with current requirement of having an accepted ticket for non trivial changes
Reported by: | Natalia Bidart | Owned by: | Maryam Yusuf |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Maryam Yusuf | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Following some feedback from https://github.com/django/django/pull/17389, there are some parts in these docs:
https://docs.djangoproject.com/en/dev/internals/contributing/bugs-and-features/
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/
that could benefit from being more explicit about the need to have an accepted ticket when working on non trivial changes.
Specifically, I think that this paragraph is misleading:
"As with most open-source projects, code talks. If you are willing to write the code for the feature yourself or, even better, if you’ve already written it, it’s much more likely to be accepted. Fork Django on GitHub, create a feature branch, and show us your work!"
And also the patch review checklist should explicitly mention that an accepted ticket is required to get reviews/discussion in a GH PR.
Change History (10)
comment:1 by , 6 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 6 months ago
- I think this paragraph "As with most open-source projects, code talks..." is kinda contradictory with what is stated above and can be deleted. I traced its Git history but didn't find out why it was added while there is a lot of emphasis on submitting tickets first.
- Obviously, the patch review checklist requires reviews/discussion in its PR, but we can add it to the patch review checklist section.
comment:3 by , 6 months ago
I want to work on this. I have gone through the PR(https://github.com/django/django/pull/17389) to see the feedback. Will assign it to myself and work on it.
comment:4 by , 6 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:5 by , 6 months ago
Cc: | added |
---|---|
Has patch: | set |
comment:6 by , 6 months ago
Patch needs improvement: | set |
---|
comment:7 by , 5 months ago
Patch needs improvement: | unset |
---|---|
Summary: | Modernize contributing pages to aling with current requirement of having an accepted ticket for non trivial changes → Modernize contributing pages to align with current requirement of having an accepted ticket for non trivial changes |
comment:8 by , 5 months ago
Patch needs improvement: | set |
---|
comment:9 by , 5 months ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |