Opened 12 months ago

Closed 11 months ago

#35092 closed New feature (fixed)

Expose additional data in responses from geoip2 queries.

Reported by: Nick Pope Owned by: Nick Pope
Component: GIS Version: dev
Severity: Normal Keywords: geoip2
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I'd like to expose some of the data missing in the responses returned for both country and city queries.

For country responses, we should return continent_code, continent_name, and is_in_european_union1.

For city responses, we should return accuracy_radius and region_name. We should also rename region to region_code and dma_code2 to metro_code. (In my initial patch I've kept the old names around for backward compatibility, but perhaps we should deprecate those keys?)

1 This was already added for city responses in #30447.
2 IIRC this is an old name for metro_code that was used in the old v1 of the GeoIP library...

Change History (4)

comment:1 by Nick Pope, 12 months ago

Has patch: set

​PR

comment:2 by Mariusz Felisiak, 12 months ago

Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak, 11 months ago

Triage Stage: Accepted → Ready for checkin

comment:4 by GitHub <noreply@…>, 11 months ago

Resolution: → fixed
Status: assigned → closed

In f50184a8:

Fixed #35092 -- Exposed extra fields for GeoIP2.country() and GeoIP2.city() responses.

Note: See TracTickets for help on using tickets.
Back to Top