Turn link to change password form in admin user change form into a button

[Fabian Braun]

Currently, to change a user's password the admin user must got to the change user form, find the password field and click a link in its help text.

For better user guidance and accessibility, I suggest turning this link into a button:

As David Smith pointed out, links in help texts are not read by screen readers:

"Do not include links within hint text. While screen readers will read out the link text when describing the field, they will not tell users that the text is a link." (​https://design-system.service.gov.uk/components/text-input/#hint-text).

I'll be happy to provide a patch.

[Fabian Braun]

Current link to change password form

[Fabian Braun]

Potential new change or (in this case) set password button.

[Natalia Bidart]

I added some review comments proposing a slightly different approach: instead of having either a link or a button *in* the help text, I would like that we separate the help text legend from the "convenience shortcut" to hint the admin user where they can act regarding the password.

I'd like the accessibility team's input, I attached a possible diff to the ​linked PR.

[Abhii67534]

I would like to work on this issue :)

[Natalia Bidart]

Replying to Abhii67534:

I would like to work on this issue :)

Thank you for your interest in helping, but there is already a submitted PR solving this issue, we are just waiting on some specific feedback.

[Natalia Bidart]

Setting as patch needs improvement until conflicts are solved and the PR is reviewable again.

[Natalia <124304+nessita@…>]

In 944745af:

Fixed #34977 -- Improved accessibility in the UserChangeForm by replacing the reset password link with a button.

Co-authored-by: Natalia <124304+nessita@…>