RelatedFieldWidgetWrapper links toggling isn’t working for radio widgets

[Thibaud Colas]

Spotted as part of #34622. In the Redirects contrib module, when creating a new redirect, the first field is for a Site instance. This is using a radio button (radio_fields ModelAdmin definition: ​https://github.com/django/django/blob/main/django/contrib/redirects/admin.py#L10). This uses RelatedFieldWidgetWrapper – which doesn’t work for radio widgets. Demo:

If we look at ​RelatedObjectLookups.js, it seems clear this code was only written to support select widgets.

Tagging this contrib.admin because it seems to affect all usage of RelatedFieldWidgetWrapper – but as far as I can see in Django itself only contrib.redirects uses radio_fields.

---

In this instance I believe a select widget would be a much nicer experience anyway, so not entirely sure whether it makes sense to change the widget to fix this, or update the code to support radio buttons, or do both.

[Natalia Bidart]

Accepting since I could easily reproduce the issue. In my opinion, we could perhaps do two things:

1- Separately consider whether the redirects app should be changed to use a select instead of a radioselect (think of a project with lots of Django Sites, the radio buttons would consume a lot of screen) This would be a separated ticket for the redirects site.

2- Actually fix the admin's RelatedFieldWidgetWrapper to work with radioselect or clealry document that only selects are supported.

[Coen van der Kamp]

I'll will first attempt 2.a: "Actually fix the admin's RelatedFieldWidgetWrapper to work with radioselect".

[Coen van der Kamp]

PR: ​https://github.com/django/django/pull/17158

[Anirudh Prabhakaran]

Hello! What is the status of this ticket?

I am planning to apply for GSoC, and so I think that trying to solve a ticket would give me a chance to get my hands dirty with the codebase. If this is not assigned to anyone, can I take a look?

[Natalia Bidart]

Replying to Anirudh Prabhakaran:

Hello! What is the status of this ticket?

I am planning to apply for GSoC, and so I think that trying to solve a ticket would give me a chance to get my hands dirty with the codebase. If this is not assigned to anyone, can I take a look?

Hello Anirudh, this ticket is free to be worked on. You can use the existing PR as a starting point. Thanks for wanting to contribute to Django!

[Sasa Cocic-Banjanac]

This ticket looks unassigned and it seems no one is currently working on it. I'd like to try to tackle it and put up a PR if there are no objections.

[bartalor]

Replying to Sasa Cocic-Banjanac:

This ticket looks unassigned and it seems no one is currently working on it. I'd like to try to tackle it and put up a PR if there are no objections.

Are you still working on the issue ?
if not, I'd like to try have a go on it :)

[JaeHyuckSa]

I will submit a PR by the end of today.