Ensure FilteredSelectMultiple select elements are associated with their label

[Cheuk Ting Ho]

In the admin UI, the FilteredSelectMultiple is missing labels for some of its elements. Here’s a recording of the widget’s UI, and what users would get for it in VoiceOver:

There are two problems here:

• "Filter edit text" – it’s not ideal for both of those to have the same label. Ideally each side would have a separate label ("Filter Available permissions", "Filter Chosen permissions"). This could be achieved with adding an aria-describedby on the filter input elements, pointing to the "Available permissions" text (and same for chosen permissions).
• "list box" – those select elements don’t have a label at all. This needs to be added by transforming the h2 elements into label, with a for pointing at each field.

HTML markup:

<select name="permissions_old" id="id_permissions_from" multiple="" class="filtered" data-field-name="permissions" data-is-stacked="0">

---

This is in admin/auth/group/add/. In Django itself, only contrib.auth group and user model forms use the filter_horizontal ModelAdmin API which has the issue. Not quite sure whether this widget is meant to be reused by users or not. We suspect is the JS widget modified the label generated. The problematic select elements:

• ​https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/SelectFilter2.js#L16
• ​https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/SelectFilter2.js#L113

And where their labels need to be created:

• ​https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/SelectFilter2.js#L38
• ​https://github.com/django/django/blob/main/django/contrib/admin/static/admin/js/SelectFilter2.js#L83

[Mariusz Felisiak]

in admin/auth/group/add/ is lacking the accessible name for the selected. We suspect is the JS widget modified the label generated.

Are we talking about aria-label? Sorry, I'm not an expert in this area.

Tentatively accepted as I believe you discussed this with Thibaud.

[Thibaud Colas]

Edited the title a bit – we did discuss this. Though aria-label would be an option, there are visible labels for both select elements where this issue appears, so the best thing to do here would be for those labels to use <label> elements with the appropriate for attribute set to the id of the <select>.

Currently those label elements use h2. We could either add a label within the h2, or replace h2 with label only.

[Thibaud Colas]

@Amanda, just a heads’up someone else has been working on this already as part of the DjangoCon Europe sprint. So it might be better for you to hold off working on this if they are still busy with it.

[Amanda Accalai]

thanks for the information. deassign the card

[Sarah Boyce]

Ref #35687 is a duplicate
From that ticket:

• "Choose all" is not related to it's tooltip help text (see "Other issues" video file)
• The help text "Hold down “Control”, or “Command” on a Mac, to select more than one." should be associated to the select box(es) (see "Other issues" video file)

Possibly the whole thing should be a fieldset with a legend

[Sarah Boyce]

The help text "Hold down “Control”, or “Command” on a Mac, to select more than one." should be associated to the select box(es) (see "Other issues" video file)

This is an issue a more general issue with admin fieldsets, see #35892.

[Sarah Boyce <42296566+sarahboyce@…>]

In 857b1048:

Fixed #34619 -- Associated FilteredSelectMultiple elements to their label and help text.