Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#34470 closed Bug (fixed)

client_encoding is no longer enforce on PostgreSQL.

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: 4.2
Severity: Release blocker Keywords:
Cc: Florian Apolloner, Anders Kaseorg Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

client_encoding defined in get_connection_params() is always overridden in the following ​code.

Regression in 6a2165816394ab4bb259f6171e82417e098e97a6.

Change History (6)

comment:1 by Mariusz Felisiak, 21 months ago

Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

By default, client encoding is the encoding defined by the database but we should still enforce utf-8.

comment:2 by Mariusz Felisiak, 21 months ago

Has patch: set

​PR

comment:3 by Mariusz Felisiak, 21 months ago

Summary: client_encoding is no longer set on PostgreSQL. → client_encoding is no longer enforce on PostgreSQL.

comment:4 by Mariusz Felisiak, 21 months ago

Triage Stage: Unreviewed → Accepted

I "accepted" based on the Florian's approval on PR.

comment:5 by GitHub <noreply@…>, 21 months ago

Resolution: → fixed
Status: assigned → closed

In 5b8a043:

Fixed #34470 -- Enforced UTF-8 encoding on PostgreSQL.

Regression in 6a2165816394ab4bb259f6171e82417e098e97a6.

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 21 months ago

In b0d7753d:

[4.2.x] Fixed #34470 -- Enforced UTF-8 encoding on PostgreSQL.

Regression in 6a2165816394ab4bb259f6171e82417e098e97a6.
Backport of 5b8a043bf51ab8bcf4a758d0b4646f30a84be183 from main

Note: See TracTickets for help on using tickets.
Back to Top