Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#34316 closed Bug (fixed)

Visual regressions in admin's change password form

Reported by: Mariusz Felisiak Owned by: Sarah Boyce
Component: contrib.admin Version: 4.2
Severity: Release blocker Keywords:
Cc: Tom Carrick, Sarah Boyce Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Mariusz Felisiak)

I noticed two visual regressions in 96a598356a9ea8c2c05b22cadc12e256a3b295fd:

  • There is no gap before the "this form" link on the "Change user" form:


  • Inputs are in the wrong place (as far as I'm aware <div>...</div> is missing around <label> and <input>) on the "Change password" form:


  • Inputs are in the wrong place (as far as I'm aware <div>...</div> is missing around <label> and <input>) on the "Password change" form:


Attachments (3)

this_form_after.png​ (14.9 KB ) - added by Mariusz Felisiak 2 years ago.
change_password_after.png​ (32.1 KB ) - added by Mariusz Felisiak 2 years ago.
password_change_after.png​ (39.3 KB ) - added by Mariusz Felisiak 2 years ago.

Download all attachments as: .zip

Change History (16)

by Mariusz Felisiak, 2 years ago

Attachment: this_form_after.png​ added

by Mariusz Felisiak, 2 years ago

Attachment: change_password_after.png​ added

by Mariusz Felisiak, 2 years ago

Attachment: password_change_after.png​ added

comment:1 by Mariusz Felisiak, 2 years ago

Description: modified (diff)

comment:2 by ulr0, 2 years ago

Owner: changed from nobody to ulr0
Status: new → assigned

comment:3 by Mariusz Felisiak, 2 years ago

Cc: Sarah Boyce added

comment:4 by Carlton Gibson, 2 years ago

Triage Stage: Unreviewed → Accepted

comment:5 by Sarah Boyce, 2 years ago

Has patch: set
Owner: changed from ulr0 to Sarah Boyce

​https://github.com/django/django/pull/16548

comment:6 by Mariusz Felisiak, 2 years ago

Patch needs improvement: set

comment:7 by Mariusz Felisiak, 2 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In e6780466:

Fixed #34316 -- Fixed layout of admin password change forms and help texts.

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In 5510a12c:

[4.2.x] Fixed #34316 -- Fixed layout of admin password change forms and help texts.

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

Backport of e67804668115fd388e7554c6a809bd409f70adfe from main

comment:10 by GitHub <noreply@…>, 22 months ago

In 39d1e45:

Refs #34316 -- Fixed displaying error lists in admin password change forms on small screens.

Follow up to e67804668115fd388e7554c6a809bd409f70adfe.

comment:11 by Mariusz Felisiak <felisiak.mariusz@…>, 22 months ago

In b85dd83:

[4.2.x] Refs #34316 -- Fixed displaying error lists in admin password change forms on small screens.

Follow up to e67804668115fd388e7554c6a809bd409f70adfe.
Backport of 39d1e45227e060746ed461fddde80fa2b6cf0dcd from main

comment:12 by GitHub <noreply@…>, 22 months ago

In f5c5c57:

Refs #34316 -- Fixed layout of admin password change forms and help texts for RTL languages.

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

Follow up to e67804668115fd388e7554c6a809bd409f70adfe and
39d1e45227e060746ed461fddde80fa2b6cf0dcd.

comment:13 by Mariusz Felisiak <felisiak.mariusz@…>, 22 months ago

In ded3334:

[4.2.x] Refs #34316 -- Fixed layout of admin password change forms and help texts for RTL languages.

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

Follow up to e67804668115fd388e7554c6a809bd409f70adfe and
39d1e45227e060746ed461fddde80fa2b6cf0dcd.
Backport of f5c5c571d3b87a78d005ea6f21959388d1747696 from main

Note: See TracTickets for help on using tickets.
Back to Top