Opened 2 years ago
Closed 2 years ago
#34266 closed New feature (fixed)
Add ClosestPoint function to GeoDjango
| Reported by: | Niccolò Mineo | Owned by: | Paolo Melchiorre |
|---|---|---|---|
| Component: | GIS | Version: | dev |
| Severity: | Normal | Keywords: | geodjango, function |
| Cc: | Paolo Melchiorre | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
I'd like to suggest adding this function to the bunch to encourage people to prefer its use in a number of situations over cumbersome solutions.
Change History (8)
comment:1 by , 2 years ago
| Cc: | added |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 2 years ago
It's fine for me to continue reviewing this PR, I wait for Nicco to integrate the documentation and proceed to review again.
follow-up: 4 comment:3 by , 2 years ago
| Description: | modified (diff) |
|---|
comment:4 by , 2 years ago
Replying to Niccolò Mineo:
I've just integrated the change in the release log: https://github.com/django/django/pull/16449. Thanks to you both.
comment:5 by , 2 years ago
| Description: | modified (diff) |
|---|
comment:6 by , 2 years ago
| Description: | modified (diff) |
|---|
comment:7 by , 2 years ago
| Keywords: | geodjango function added |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
| Triage Stage: | Accepted → Ready for checkin |
| Version: | 4.1 → dev |
The PR looks to me ready for squash commits and merge.
Note:
See TracTickets
for help on using tickets.
OK, I'll accept this.
At the general level we try include only those function that have wide utility, in order to keep the scope manageable. (It's normally quite easy to add a needed function wrapper to a user's project.)
This seems quite handy to me, so +1, but I'm not a big GeoDjango user up to now, so CCing Paolo (since you are and you already commented on the PR.)