Flatpages manipulates url before get_object_or_404 leads to error

[Snake-Soft]

Django flatpages has some unwanted behaviour can lead to a catched exception that is not easy to resolve.
This problem occurs when saving a FlatPage object without a leading slash in the url.

The view is located in:

django.contrib.flatpages.views

This is the problematic flatpage view:

def flatpage(request, url):
    if not url.startswith('/'):
        url = '/' + url
    site_id = get_current_site(request).id
    try:
        f = get_object_or_404(FlatPage, url=url, sites=site_id)
    except Http404:
        if not url.endswith('/') and settings.APPEND_SLASH:
            url += '/'
            f = get_object_or_404(FlatPage, url=url, sites=site_id)
            return HttpResponsePermanentRedirect('%s/' % request.path)
        else:
            raise
    return render_flatpage(request, f)

I think it doesn't make sense to manipulate the url at this point because nothing happens with the url between manipulating an fetching the FlatPage from db.

[Mariusz Felisiak]

Thanks for this ticket, however I'm not sure what you're proposing or what kind of issue you want to report. Also URL should have a leading slash: