Opened 4 years ago

Closed 4 years ago

#32765 closed Cleanup/optimization (fixed)

Label for ReadOnlyPasswordHashWidget points to non-labelable element.

Reported by: David Sanders Owned by: David Sanders
Component: contrib.auth Version: 3.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by David Sanders)

In the admin, the label element for the ReadOnlyPasswordHashWidget widget has a 'for' attribute which points to a non-labelable element, since the widget just renders text, not an input. There's no labelable element for the widget, so the label shouldn't have a 'for' attribute.

Change History (5)

comment:1 by David Sanders, 4 years ago

Has patch: set

comment:2 by Mariusz Felisiak, 4 years ago

Needs tests: set
Summary: Label for ReadOnlyPasswordHashWidget points to non-existent HTML ID → Label for ReadOnlyPasswordHashWidget points to non-labelable element.
Triage Stage: Unreviewed → Accepted
Type: Bug → Cleanup/optimization

Agreed, currently it's associated with <div> which is not a labelable element, see ​spec.

​PR

comment:3 by David Sanders, 4 years ago

Description: modified (diff)

comment:4 by Mariusz Felisiak, 4 years ago

Needs tests: unset
Owner: changed from nobody to David Sanders
Status: new → assigned
Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 536c155e:

Fixed #32765 -- Removed "for" HTML attribute from ReadOnlyPasswordHashWidget.

ReadOnlyPasswordHashWidget doesn't have any labelable elements.

Note: See TracTickets for help on using tickets.
Back to Top