Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#32375 closed Cleanup/optimization (fixed)

Make Sitemap's protocol default to "https".

Reported by: Thomas Güttler Owned by: Rohith P R
Component: contrib.sitemaps Version: dev
Severity: Normal Keywords: sitemap, protocol, https
Cc: Jerin Peter George Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

I think it is time to change the default of Sitemap.protocol to https.

​https://docs.djangoproject.com/en/3.1/ref/contrib/sitemaps/#django.contrib.sitemaps.Sitemap.protocol

Of course slowly with a clear deprecation timeline.

What do you think?

Change History (10)

comment:1 by Mariusz Felisiak, 4 years ago

Summary: Sitemap.protocol change default to 'https'? → Make Sitemap's protocol default to "https".
Triage Stage: Unreviewed → Accepted
Type: New feature → Cleanup/optimization
Version: 3.1 → master

Sounds reasonable. We can add a warning for changing the default and switch it when the deprecation ends (as in 9a30acad8a1996c914351bad981d937de4db29a4). Would you like to provide a patch?

comment:2 by Jerin Peter George, 4 years ago

Cc: Jerin Peter George added
Owner: changed from nobody to Jerin Peter George
Status: new → assigned

comment:3 by David Smith, 4 years ago

Easy pickings: set

comment:4 by Rohith P R, 4 years ago

Has patch: set
Owner: changed from Jerin Peter George to Rohith P R

comment:5 by Nick Pope, 4 years ago

Keywords: sitemap protocol https added
Patch needs improvement: set

​PR

comment:6 by Rohith P R, 4 years ago

Patch needs improvement: unset

comment:7 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:8 by Mariusz Felisiak, 4 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 7cca2296:

Fixed #32375 -- Started deprecation toward changing the default sitemap protocol to https.

The default sitemap protocol, when it is built outside the context of
a request, will be changed from 'http' to 'https' in Django 5.0.

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In 4eb97a90:

Refs #32375 -- Changed default sitemap protocol to https.

Per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top