Opened 5 years ago
Closed 5 years ago
#31642 closed Cleanup/optimization (wontfix)
Some static assets in the Admin site fail to fetch (using custom storage)
| Reported by: | Evan Babb | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | 3.0 |
| Severity: | Normal | Keywords: | staticfiles, admin, storages |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
My integration with django_storages fails to load certain assets in the default Django admin, because they don't get the access GET params appended to them.
There are workarounds related to making the static files bucket in S3 "public" but it seems like that doesn't necessarily meet all use cases.
see related issue in Django Storages project: https://github.com/jschneier/django-storages/issues/734
Examples of urls in the admin base CSS that fail in private buckets:
https://github.com/django/django/blob/master/django/contrib/admin/static/admin/css/base.css#L5
https://github.com/django/django/blob/master/django/contrib/admin/static/admin/css/base.css#L641
Change History (2)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
| Type: | Bug → Cleanup/optimization |
I agree with Tim. You should be able to rewrite the CSS stylesheet if you really need to serve them from a private bucket.
I'm not sure what Django could do besides rendering the CSS files using the template system to allow using the
{% static %}tag for those references? I tend to think that it's not worth imposing that performance penalty on all Django sites.