#30127 closed Cleanup/optimization (fixed)
Deprecate cached_property's name argument
| Reported by: | Tim Graham | Owned by: | Marcelo Galigniana |
|---|---|---|---|
| Component: | Utilities | Version: | dev |
| Severity: | Normal | Keywords: | 4.0 |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Django 2.2 is the last version to support Python 3.5 where cached_property's name argument is required. Following the release of Django 4.0, most apps will drop support for Django 2.2 (and hence Python 3.5), so Django 4.0 can deprecate the name argument without giving warnings that aren't actionable as long as apps want to keep support for Python 3.5.
Change History (12)
comment:1 by , 5 years ago
comment:2 by , 4 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 3 years ago
| Easy pickings: | set |
|---|---|
| Owner: | removed |
| Status: | assigned → new |
comment:4 by , 3 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:5 by , 3 years ago
| Triage Stage: | Someday/Maybe → Accepted |
|---|---|
| Version: | 2.1 → dev |
comment:7 by , 3 years ago
| Has patch: | set |
|---|
follow-up: 9 comment:8 by , 3 years ago
| Patch needs improvement: | set |
|---|
You need to deprecate it (RemovedInDjango50Warning) rather than simply remove it.
comment:9 by , 3 years ago
| Patch needs improvement: | unset |
|---|
Sorry Tim! I hadn't read how to deprecate a feature.
I updated the PR. Let me know any necessary change!
Thank you for the answer and explanation.
Replying to Tim Graham:
You need to deprecate it (
RemovedInDjango50Warning) rather than simply remove it.
comment:10 by , 3 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
it may be worth deprecating it entirely for a py3 backport https://code.djangoproject.com/ticket/30949#ticket