Opened 8 years ago

Closed 8 years ago

#28226 closed Cleanup/optimization (fixed)

Remove use of deprecated ''.join() pattern

Reported by: James Bennett Owned by: nobody
Component: HTTP handling Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

From Lennart Regebro's PyCon 2017 talk: we're using this in django/http/multipartparser.py where it's no longer necessary (concatenation is now faster on every version of Python we support).

Change History (4)

comment:1 by Claude Paroz, 8 years ago

Any pointer to the Python docs or any other reference article?

comment:2 by Claude Paroz, 8 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

Oh, I didn't see the ​PR at first. Is it WIP? Should we search for other patterns like this?

comment:3 by Tom Forbes, 8 years ago

I added another patch here: ​https://github.com/django/django/pull/8527

I fixed all the places I could find where .join has static arguments, there could be a few left (there are a lot of join statements in Django!).

comment:4 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In 7afb476:

Fixed #28226 -- Replaced use of str.join() with concatenation.

Note: See TracTickets for help on using tickets.
Back to Top