Opened 8 years ago

Closed 8 years ago

#27787 closed Cleanup/optimization (fixed)

call_command() should validate the arguments it receives

Reported by: Tim Graham Owned by: Chandrakant Kumar
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In #27769 it was observed that call_command() doesn't reject unknown options. In that case, noinput=True was passed rather than interactive=False. It would be nice if such errors didn't pass silently.

Change History (10)

comment:1 by Srinivas Reddy Thatiparthy, 8 years ago

Owner: changed from nobody to Srinivas Reddy Thatiparthy
Status: new → assigned

comment:3 by Claude Paroz, 8 years ago

Needs tests: set

comment:4 by Chandrakant Kumar, 8 years ago

Needs tests: unset

​https://github.com/django/django/pull/7979

comment:5 by Tim Graham, 8 years ago

Patch needs improvement: set

The patch is still not ready for review given tests aren't passing and release notes about possible backwards incompatibilities are missing.

comment:6 by Chandrakant Kumar, 8 years ago

Patch needs improvement: unset

​https://github.com/django/django/pull/8036

comment:7 by Chandrakant Kumar, 8 years ago

Owner: changed from Srinivas Reddy Thatiparthy to Chandrakant Kumar

comment:8 by Tim Graham <timograham@…>, 8 years ago

In f6800a08:

Refs #27787 -- Corrected or removed invalid call_command() options.

comment:9 by Tim Graham, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:10 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 2b09e4c8:

Fixed #27787 -- Made call_command() validate the options it receives.

Note: See TracTickets for help on using tickets.
Back to Top